Update to new pac #371
Update to new pac #371
Conversation
|
I had to enable the feature |
src/watchdog.rs
Outdated
|
|
||
| let psc = self.iwdg.pr.read().pr().variant(); | ||
| let reload = self.iwdg.rlr.read().rl().bits(); | ||
| let psc = self.iwdg.pr().read().pr().variant().unwrap(); // <--- Unwrap!! |
There was a problem hiding this comment.
Any thoughts as to what to do here? Should we provide a default or something? Or can this possibly fail?
There was a problem hiding this comment.
Looks like H5 guy has broke this:
stm32-rs/stm32-rs@c812a9e
There should be default 256 value
There was a problem hiding this comment.
There was a problem hiding this comment.
Perfect, thanks a lot! stm32-rs/stm32-rs#1045
|
Correct me if I am wrong, but I do not think I am guilty to this one error[E0599]: no method named `split` found for struct `Serial` in the current scope
--> examples/serial_dma.rs:44:27
|
44 | let (tx, rx) = serial.split();
| ^^^^^ method not found in `Serial<USART1, (Pin<Gpioa, U<9>, Alternate<PushPull, 7>>, Pin<Gpioa, U<10>, Alternate<PushPull, 7>>)>`
|
= note: the full type name has been written to '/home/runner/work/stm32f3xx-hal/stm32f3xx-hal/target/thumbv7em-none-eabihf/debug/examples/serial_dma-091110dd37752b66.long-type-1484845090031692940.txt'
= note: consider using `--verbose` to print the full type name to the console |
|
@burrbull would you like to take a look at this? |
src/spi.rs
Outdated
| let write_ptr = core::ptr::addr_of!(self.spi.dr) as *mut Word; | ||
| let write_ptr = self.spi.dr().as_ptr() as *mut Word; | ||
| // SAFETY: Write to register owned by this Spi struct | ||
| unsafe { core::ptr::write_volatile(write_ptr, word) }; |
There was a problem hiding this comment.
I'd recommend to use dr register for Word = u16 and dr8 register for Word = u8 so you don't need for casting:
self.spi.dr8().write(|w| dr().set(word));Same for reading.
| channel::Id::Sixteen => self.reg.smpr2.read().smp16().variant().into(), | ||
| channel::Id::Seventeen => self.reg.smpr2.read().smp17().variant().into(), | ||
| channel::Id::Eighteen => self.reg.smpr2.read().smp18().variant().into(), | ||
| channel::Id::Zero => self.adc.smpr1().read().smp0().variant().into(), |
There was a problem hiding this comment.
If you specify channel::Id::Zero as 0 you could write it shorter:
let ch = channel as u8
if ch < 9 {
self.adc.smpr1.read().smp(ch).variant().into()
} else {
self.adc.smpr1.read().smp(ch - 9).variant().into()
}There was a problem hiding this comment.
Like this a8f8835?
Edit: I think i got some errors
There was a problem hiding this comment.
They dont seem to be array-ified
There was a problem hiding this comment.
Sorry. You are right. I've not finished this yet.
This updates this hal to use the stm32f3-staging pac. I am doing this in an attempt to get the HRTIM peripheral to work.